cdsbalancer: Remove UpdateAddresses handling#8811
Merged
arjan-bal merged 2 commits intogrpc:masterfrom Jan 16, 2026
Merged
Conversation
arjan-bal
added
Type: Internal Cleanup
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8811 +/- ##
==========================================
+ Coverage 83.25% 83.40% +0.14%
==========================================
Files 417 417
Lines 32978 32976 -2
==========================================
+ Hits 27457 27503 +46
+ Misses 4106 4074 -32
+ Partials 1415 1399 -16
🚀 New features to boost your workflow:
|
Contributor
|
@eshitachandwani : Please consider yourself as the primary reviewer of this PR. And loop me in once you have approved it. Thanks. |
eshitachandwani
approved these changes
Jan 10, 2026
easwars
approved these changes
Jan 15, 2026
mbissa
pushed a commit
to mbissa/grpc-go
that referenced
this pull request
Feb 16, 2026
Following the dual-stack changes that established `pick_first` as the universal leaf policy and the subsequent removal of the legacy `pick_first` implementation, `ClientConn.UpdateAddresses` is no longer utilized within the xDS LB policy tree. When addresses change, old `SubConns` are now shut down and new ones are created. This PR makes `UpdateAddresses` a no-op. RELEASE NOTES: N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the dual-stack changes that established
pick_firstas the universal leaf policy and the subsequent removal of the legacypick_firstimplementation,ClientConn.UpdateAddressesis no longer utilized within the xDS LB policy tree. When addresses change, oldSubConnsare now shut down and new ones are created.This PR makes
UpdateAddressesa no-op.RELEASE NOTES: N/A